mbirth/LuckyCoinkydink
Archived
1
0
Fork 0
Code Issues Pull Requests Activity

resp imgs: don't insert original image if too small

Browse Source
This commit is contained in:
onli
2017-12-16 22:21:45 +01:00
parent 967935195c
commit 4d30cf3b07
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
plugins/serendipity_event_responsiveimages/serendipity_event_responsiveimages.php
View File

@ -18,7 +18,7 @@ class serendipity_event_responsiveimages extends serendipity_event
$propbag->add('description', PLUGIN_EVENT_RESPONSIVE_DESC); $propbag->add('description', PLUGIN_EVENT_RESPONSIVE_DESC);
$propbag->add('stackable', false); $propbag->add('stackable', false);
$propbag->add('author', 'Serendipity Team'); $propbag->add('author', 'Serendipity Team');
$propbag->add('version', '0.3'); $propbag->add('version', '0.4');
$propbag->add('requirements', array( $propbag->add('requirements', array(
'serendipity' => '2.2', 'serendipity' => '2.2',
)); ));
@ -78,9 +78,9 @@ class serendipity_event_responsiveimages extends serendipity_event
$hooks = &$bag->get('event_hooks'); $hooks = &$bag->get('event_hooks');
$this->breakpoints = $serendipity['smarty']->getTemplateVars('template_option')['breakpoints']; $this->breakpoints = $serendipity['smarty']->getTemplateVars('template_option')['breakpoints'];
if (! $this->breakpoints) { if (! $this->breakpoints) {
$this->breakpoints = [1600, 1200, 600]; # This can later on be overwritten by the theme $this->breakpoints = [1600, 1200, 600]; # This can be overwritten by the theme
} }
$this->thumbWidths = [1200, 800, 400]; # This can later on be overwritten by the theme $this->thumbWidths = [1200, 800, 400];
if (isset($hooks[$event])) { if (isset($hooks[$event])) {
@ -170,6 +170,10 @@ class serendipity_event_responsiveimages extends serendipity_event
$thumbnails = serendipity_getThumbnails($id); $thumbnails = serendipity_getThumbnails($id);
$srcset = "srcset=\"$imagePath {$origImage['dimensions_width']}w,"; $srcset = "srcset=\"$imagePath {$origImage['dimensions_width']}w,";
if ($origImage['dimensions_width'] <= $this->breakpoints[0]) {
// don't set the original image as srcset source if its breakpoint would be too small
$srcset = 'srcset="';
}
for ($i = 0; $i < count($this->thumbWidths); $i++) { for ($i = 0; $i < count($this->thumbWidths); $i++) {
$thumbWidth = $this->thumbWidths[$i]; $thumbWidth = $this->thumbWidths[$i];
@ -186,6 +190,10 @@ class serendipity_event_responsiveimages extends serendipity_event
$srcset .= "{$thumbnailHttp} {$breakpoint}w,"; $srcset .= "{$thumbnailHttp} {$breakpoint}w,";
} }
} }
if (substr($srcset, -strlen(',')) === ',') {
// we don't want to have the trailing comma
$srcset = substr($srcset, 0, -1);
}
$srcset .= '"'; $srcset .= '"';