mbirth/LuckyCoinkydink
1
0
Fork 0
Code Issues Pull Requests Activity

Do not print errors for PHP warnings in production mode

Browse Source 
Not even when logged in. The error output stopped the script execution. This change enables the usage of old themes, if their critical issues are fixed
This commit is contained in:
onli 2021-07-01 22:03:45 +02:00
parent 34f52d1aae
commit 8d8aa4ce66
1 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
include/compat.inc.php
View File

@ -214,27 +214,6 @@ if (!function_exists('errorToExceptionHandler')) {
if (!$serendipity['dbConn'] || $exit) { if (!$serendipity['dbConn'] || $exit) {
exit; // make sure to exit in case of database connection errors or fatal errors. exit; // make sure to exit in case of database connection errors or fatal errors.
} }
} else {
// Only display error (production blog) if an admin is logged in, else we discard the error.
if ($serendipity['serendipityUserlevel'] >= USERLEVEL_ADMIN) {
$str = " == SERENDIPITY ERROR == ";
$str .= '<p><b>' . $type . ':</b> '.$errStr . ' in ' . $errFile . ' on line ' . $errLine . '.' . $debug_note . '</p>';
if (headers_sent()) {
serendipity_die($str); // case HTTP headers: needs to halt with die() here, else it will path through and gets written underneath blog content, or into streamed js files, which hardly isn't seen by many users
} else {
// see global include of function in plugin_api.inc.php
// this also reacts on non eye-displayed errors with following small javascript,
// while being in tags like <select> to push on top of page, else return non javascript use $str just there
// sadly we can not use HEREDOC notation here, since this does not execute the javascript after finished writing
echo "\n".'<script>
if (typeof errorHandlerCreateDOM == "function") {
var fragment = window.top.errorHandlerCreateDOM("Error redirect: '.addslashes($str).'");
document.body.insertBefore(fragment, document.body.childNodes[0]);
}' . "\n</script>\n<noscript>" . $str . "</noscript>\n";
}
}
} }
} }
} }