From 9bf64cccdad44383c872598934f3cf6369be2f2e Mon Sep 17 00:00:00 2001 From: Garvin Hicking <blog@garv.in> Date: Wed, 5 Mar 2014 13:28:26 +0100 Subject: [PATCH] example() method needs to RETURN not echo. --- .../serendipity_event_contentrewrite.php | 2 +- plugins/serendipity_event_nl2br/serendipity_event_nl2br.php | 2 +- plugins/serendipity_event_textile/serendipity_event_textile.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/serendipity_event_contentrewrite/serendipity_event_contentrewrite.php b/plugins/serendipity_event_contentrewrite/serendipity_event_contentrewrite.php index dbe9c6a8..f197b597 100644 --- a/plugins/serendipity_event_contentrewrite/serendipity_event_contentrewrite.php +++ b/plugins/serendipity_event_contentrewrite/serendipity_event_contentrewrite.php @@ -126,7 +126,7 @@ class serendipity_event_contentrewrite extends serendipity_event } function example() { - printf(PLUGIN_EVENT_CONTENTREWRITE_REWRITESTRING, $this->fromstring, $this->tostring); + return sprintf(PLUGIN_EVENT_CONTENTREWRITE_REWRITESTRING, $this->fromstring, $this->tostring); } function install() { diff --git a/plugins/serendipity_event_nl2br/serendipity_event_nl2br.php b/plugins/serendipity_event_nl2br/serendipity_event_nl2br.php index 83cdf5cb..92092126 100644 --- a/plugins/serendipity_event_nl2br/serendipity_event_nl2br.php +++ b/plugins/serendipity_event_nl2br/serendipity_event_nl2br.php @@ -86,7 +86,7 @@ class serendipity_event_nl2br extends serendipity_event } function example() { - echo '<h3>PLEASE NOTE the implications of this markup plugin:</h3> + return '<h3>PLEASE NOTE the implications of this markup plugin:</h3> <p>This plugin transfers linebreaks to HTML-linebreaks, so that they show up in your blog entry.</p> <p>In two cases this can raise problematic issues for you:</p> <ul> diff --git a/plugins/serendipity_event_textile/serendipity_event_textile.php b/plugins/serendipity_event_textile/serendipity_event_textile.php index 01b7a3fa..c19434a6 100644 --- a/plugins/serendipity_event_textile/serendipity_event_textile.php +++ b/plugins/serendipity_event_textile/serendipity_event_textile.php @@ -77,7 +77,7 @@ class serendipity_event_textile extends serendipity_event } function example() { - echo '<p>'.PLUGIN_EVENT_TEXTILE_EXAMPLE_NOTE.'</p>'; + return '<p>'.PLUGIN_EVENT_TEXTILE_EXAMPLE_NOTE.'</p>'; } function introspect_config_item($name, &$propbag)