mbirth/LuckyCoinkydink
Archived
1
0
Fork 0
Code Issues Pull Requests Activity

Use return instead of echo in the remaining core

Browse Source 
Debug-messages still may use echo, and some functions in functions_image and trackback still use it to generate progress messages, which should get cleaned up as well but is not that urgent
This commit is contained in:
onli
2013-07-05 19:16:11 +02:00
parent 0614fcdf51
commit d80a8334c8
16 changed files with 51 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/serendipity_event_statistics/serendipity_event_statistics.php
View File

@ -14,7 +14,7 @@ class serendipity_event_statistics extends serendipity_event
$propbag->add('description', PLUGIN_EVENT_STATISTICS_DESC);
$propbag->add('stackable', false);
$propbag->add('author', 'Arnan de Gans, Garvin Hicking, Fredrik Sandberg, kalkin');
$propbag->add('version', '1.51');
$propbag->add('version', '1.52');
$propbag->add('requirements', array(
'serendipity' => '0.8',
'smarty' => '2.6.7',
@ -532,11 +532,11 @@ class serendipity_event_statistics extends serendipity_event
<br />
<dt><strong><?php echo TOP_REFERRER; ?></strong></dt>
<dd><?php serendipity_displayTopReferrers($max_items, true); ?></dd>
<dd><?php echo serendipity_displayTopReferrers($max_items, true); ?></dd>
<br />
<dt><strong><?php echo TOP_EXITS; ?></strong></dt>
<dd><?php serendipity_displayTopExits($max_items, true); ?></dd>
<dd><?php echo serendipity_displayTopExits($max_items, true); ?></dd>
</dl>
<hr />
<?php serendipity_plugin_api::hook_event('event_additional_statistics', $eventData, array('maxitems' => $max_items)); ?>

4
plugins/serendipity_plugin_topexits/serendipity_plugin_topexits.php
View File

@ -9,7 +9,7 @@ class serendipity_plugin_topexits extends serendipity_plugin {
$propbag->add('description', SHOWS_TOP_EXIT);
$propbag->add('stackable', false);
$propbag->add('author', 'Serendipity Team');
$propbag->add('version', '1.0');
$propbag->add('version', '1.1');
$propbag->add('configuration', array('limit', 'use_links', 'interval'));
$propbag->add('groups', array('STATISTICS'));
}
@ -62,7 +62,7 @@ class serendipity_plugin_topexits extends serendipity_plugin {
$use_links = serendipity_db_bool($use_links);
}
serendipity_displayTopExits($this->get_config('limit', 10), $use_links, $this->get_config('interval', 7));
echo serendipity_displayTopExits($this->get_config('limit', 10), $use_links, $this->get_config('interval', 7));
}
}

4
plugins/serendipity_plugin_topreferrers/serendipity_plugin_topreferrers.php
View File

@ -9,7 +9,7 @@ class serendipity_plugin_topreferrers extends serendipity_plugin {
$propbag->add('description', SHOWS_TOP_SITES);
$propbag->add('stackable', false);
$propbag->add('author', 'Serendipity Team');
$propbag->add('version', '1.1');
$propbag->add('version', '1.2');
$propbag->add('configuration', array('limit', 'use_links', 'interval'));
$propbag->add('groups', array('STATISTICS'));
}
@ -61,7 +61,7 @@ class serendipity_plugin_topreferrers extends serendipity_plugin {
} else {
$use_links = serendipity_db_bool($use_links);
}
serendipity_displayTopReferrers($this->get_config('limit', 10), $use_links, $this->get_config('interval', 7));
echo serendipity_displayTopReferrers($this->get_config('limit', 10), $use_links, $this->get_config('interval', 7));
}
}