1
0

consistent plugin usage - history

this and followup commits touches:
    class method parenthesis "\n{\n    <code>\n}\n",
    case break switches,
    consistent boolean usage,
    append css to eventData
    and other cleanups
This commit is contained in:
Ian
2016-01-26 14:01:19 +01:00
parent 812219e372
commit 6be46c890e

View File

@ -1,4 +1,8 @@
<?php # $Id$
<?php
if (IN_serendipity !== true) {
die ("Don't hack!");
}
@serendipity_plugin_api::load_language(dirname(__FILE__));
@ -16,9 +20,9 @@ class serendipity_plugin_history extends serendipity_plugin
$propbag->add('description', PLUGIN_HISTORY_DESC);
$propbag->add('stackable', true);
$propbag->add('author', 'Jannis Hermanns');
$propbag->add('version', '1.6');
$propbag->add('version', '1.7');
$propbag->add('requirements', array(
'serendipity' => '0.8',
'serendipity' => '1.6',
'smarty' => '2.6.7',
'php' => '4.1.0'
));
@ -41,88 +45,102 @@ class serendipity_plugin_history extends serendipity_plugin
function introspect_config_item($name, &$propbag)
{
switch($name) {
case 'title':
$propbag->add('type', 'string');
$propbag->add('name', TITLE);
$propbag->add('description', '');
$propbag->add('default', PLUGIN_HISTORY_NAME);
break;
break;
case 'intro':
$propbag->add('type', 'string');
$propbag->add('name', PLUGIN_HISTORY_INTRO);
$propbag->add('description', PLUGIN_HISTORY_INTRO_DESC);
$propbag->add('default', '');
break;
break;
case 'outro':
$propbag->add('type', 'string');
$propbag->add('name', PLUGIN_HISTORY_OUTRO);
$propbag->add('description', PLUGIN_HISTORY_OUTRO_DESC);
$propbag->add('default', '');
break;
break;
case 'maxlength':
$propbag->add('type', 'string');
$propbag->add('name', PLUGIN_HISTORY_MAXLENGTH);
$propbag->add('description', PLUGIN_HISTORY_MAXLENGTH_DESC);
$propbag->add('default', 30);
break;
break;
case 'specialage':
$propbag->add('type', 'select');
$propbag->add('name', PLUGIN_HISTORY_SPECIALAGE);
$propbag->add('description', PLUGIN_HISTORY_SPECIALAGE_DESC);
$propbag->add('default', 'year');
$propbag->add('select_values', array('year'=>PLUGIN_HISTORY_OYA,'custom'=>PLUGIN_HISTORY_MYSELF));
break;
break;
case 'min_age':
$propbag->add('type', 'string');
$propbag->add('name', PLUGIN_HISTORY_MIN_AGE);
$propbag->add('description', PLUGIN_HISTORY_MIN_AGE_DESC);
$propbag->add('default', 365);
break;
break;
case 'max_age':
$propbag->add('type', 'string');
$propbag->add('name', PLUGIN_HISTORY_MAX_AGE);
$propbag->add('description', PLUGIN_HISTORY_MAX_AGE_DESC);
$propbag->add('default', 365);
break;
break;
case 'max_entries':
$propbag->add('type', 'string');
$propbag->add('name', PLUGIN_HISTORY_MAX_ENTRIES);
$propbag->add('description', PLUGIN_HISTORY_MAX_ENTRIES_DESC);
$propbag->add('default', 5);
break;
case 'full':
$propbag->add('type', 'boolean');
$propbag->add('name', PLUGIN_HISTORY_SHOWFULL);
$propbag->add('description', PLUGIN_HISTORY_SHOWFULL_DESC);
$propbag->add('default', false);
break;
case 'displaydate':
$propbag->add('type', 'boolean');
$propbag->add('name', PLUGIN_HISTORY_DISPLAYDATE);
$propbag->add('description', PLUGIN_HISTORY_DISPLAYDATE_DESC);
$propbag->add('default', true);
break;
case 'displayauthor':
$propbag->add('type', 'boolean');
$propbag->add('name', PLUGIN_HISTORY_DISPLAYAUTHOR);
$propbag->add('description', '');
$propbag->add('default', false);
break;
break;
case 'dateformat':
$propbag->add('type', 'string');
$propbag->add('name', GENERAL_PLUGIN_DATEFORMAT);
$propbag->add('description', sprintf(GENERAL_PLUGIN_DATEFORMAT_BLAHBLAH, '%a, %d.%m.%Y %H:%M'));
$propbag->add('default', '%a, %d.%m.%Y %H:%M');
break;
break;
case 'full':
$propbag->add('type', 'boolean');
$propbag->add('name', PLUGIN_HISTORY_SHOWFULL);
$propbag->add('description', PLUGIN_HISTORY_SHOWFULL_DESC);
$propbag->add('default', 'false');
break;
case 'displaydate':
$propbag->add('type', 'boolean');
$propbag->add('name', PLUGIN_HISTORY_DISPLAYDATE);
$propbag->add('description', PLUGIN_HISTORY_DISPLAYDATE_DESC);
$propbag->add('default', 'true');
break;
case 'displayauthor':
$propbag->add('type', 'boolean');
$propbag->add('name', PLUGIN_HISTORY_DISPLAYAUTHOR);
$propbag->add('description', '');
$propbag->add('default', 'false');
break;
default:
return false;
return false;
}
return true;
}
function generate_content(&$title)
{
global $serendipity;
global $serendipity;
$title = $this->get_config('title', $this->title);
$intro = $this->get_config('intro');
$outro = $this->get_config('outro');
@ -131,10 +149,10 @@ class serendipity_plugin_history extends serendipity_plugin
$min_age = $this->get_config('min_age');
$max_age = $this->get_config('max_age');
$specialage = $this->get_config('specialage');
$displaydate = $this->get_config('displaydate', 'true');
$displaydate = serendipity_db_bool($this->get_config('displaydate', 'true'));
$dateformat = $this->get_config('dateformat');
$full = serendipity_db_bool($this->get_config('full'));
$displayauthor = serendipity_db_bool($this->get_config('displayauthor', false));
$full = serendipity_db_bool($this->get_config('full', 'false'));
$displayauthor = serendipity_db_bool($this->get_config('displayauthor', 'false'));
if (!is_numeric($min_age) || $min_age < 0 || $specialage == 'year') {
$min_age = 365 + date('L', serendipity_serverOffsetHour());
@ -179,22 +197,29 @@ class serendipity_plugin_history extends serendipity_plugin
true,
array('timestamp' => $e[$x]['timestamp'])
);
$date = ($displaydate=='0') ? '' : serendipity_strftime($dateformat,$e[$x]['timestamp']);
$date = (!$displaydate) ? '' : serendipity_strftime($dateformat,$e[$x]['timestamp']);
$author = ($displayauthor) ? $e[$x]['author'] . ': ' : '';
echo '<div class="serendipity_history_info">';
if ($displayauthor)
{ echo '<span class="serendipity_history_author">' . $author . ' </span>'; }
if ($displaydate)
{ echo '<span class="serendipity_history_date">' . $date . ' </span>'; }
$t = ($maxlength==0 || strlen($e[$x]['title'])<=$maxlength) ?
$e[$x]['title'] :
(trim(serendipity_mb('substr', $e[$x]['title'], 0, $maxlength-3)).' [...]');
if ($displayauthor) {
echo '<span class="serendipity_history_author">' . $author . ' </span>';
}
if ($displaydate) {
echo '<span class="serendipity_history_date">' . $date . ' </span>';
}
$t = ($maxlength==0 || strlen($e[$x]['title']) <= $maxlength) ? $e[$x]['title']
: (trim(serendipity_mb('substr', $e[$x]['title'], 0, $maxlength-3)).' [...]');
echo '<a href="' . $url . '" title="' . str_replace("'", "`", serendipity_specialchars($e[$x]['title'])) . '">"' . serendipity_specialchars($t) . '"</a></div>';
if ($full)
{ echo '<div class="serendipity_history_body">' . strip_tags($e[$x]['body']) . '</div>'; }
if ($full) {
echo '<div class="serendipity_history_body">' . strip_tags($e[$x]['body']) . '</div>';
}
}
echo (empty($outro)) ? '' : '<div class="serendipity_history_outro">' . $outro . '</div>';
}
}
/* vim: set sts=4 ts=4 expandtab : */
?>